Hi--
On 10/25/23 21:56, Muhammad Muzammil wrote:
> Hi,
>
> Can anyone approve this patch?
I can review it. Please see below.
>
> On Mon, Oct 23, 2023 at 3:59 PM Muhammad Muzammil
> <m.muzzammilashraf@xxxxxxxxx> wrote:
>>
>> iscsi: iscsi_target.c: Fixed typo
>> iscsi: iscsi_target_login.c: Fixed typo
>> iscsi: iscsi_target_nego.c: Fixed typo
>> iscsi: iscsi_target_parameters.h: Fixed typo
>> iscsi: iscsi_target_tpg.c: Fixed typo
>> target_core_sbc.c: Fixed typo
>> target_core_transport.c: Fixed typo
>> target_core_user.c: Fixed typo
>> target_core_xcopy.h: Fixed typo
>> tcm_fc: tfc_conf.c: Fixed typo
>> tcm_fc: tfc_sess.c: Fixed typo
>>
>> Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@xxxxxxxxx>
>> ---
>> drivers/target/iscsi/iscsi_target.c | 2 +-
>> drivers/target/iscsi/iscsi_target_login.c | 2 +-
>> drivers/target/iscsi/iscsi_target_nego.c | 4 ++--
>> drivers/target/iscsi/iscsi_target_parameters.h | 2 +-
>> drivers/target/iscsi/iscsi_target_tpg.c | 2 +-
>> drivers/target/target_core_sbc.c | 2 +-
>> drivers/target/target_core_transport.c | 4 ++--
>> drivers/target/target_core_user.c | 4 ++--
>> drivers/target/target_core_xcopy.h | 2 +-
>> drivers/target/tcm_fc/tfc_conf.c | 2 +-
>> drivers/target/tcm_fc/tfc_sess.c | 4 ++--
>> 11 files changed, 15 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
>> index c81def3c96df..665eb2d9bc19 100644
>> --- a/drivers/target/target_core_transport.c
>> +++ b/drivers/target/target_core_transport.c
>> @@ -3447,7 +3447,7 @@ static const struct sense_detail sense_detail_table[] = {
>> * REGISTER AND MOVE service actionis attempted,
>> * but there are insufficient device server resources to complete the
>> * operation, then the command shall be terminated with CHECK CONDITION
>> - * status, with the sense key set to ILLEGAL REQUEST,and the additonal
>> + * status, with the sense key set to ILLEGAL REQUEST,and the additional
That could use a space after "REQUEST,".
>> * sense code set to INSUFFICIENT REGISTRATION RESOURCES.
>> */
>> .key = ILLEGAL_REQUEST,
>> diff --git a/drivers/target/tcm_fc/tfc_conf.c b/drivers/target/tcm_fc/tfc_conf.c
>> index 5ee03d1cba2b..4b066e14f885 100644
>> --- a/drivers/target/tcm_fc/tfc_conf.c
>> +++ b/drivers/target/tcm_fc/tfc_conf.c
>> @@ -281,7 +281,7 @@ static void ft_del_tpg(struct se_portal_group *se_tpg)
>>
>> destroy_workqueue(tpg->workqueue);
>>
>> - /* Wait for sessions to be freed thru RCU, for BUG_ON below */
>> + /* Wait for sessions to be freed through RCU, for BUG_ON below */
Correct but doesn't matter much. "thru" is very common.
>> synchronize_rcu();
>>
>> mutex_lock(&ft_lport_lock);
>> diff --git a/drivers/target/tcm_fc/tfc_sess.c b/drivers/target/tcm_fc/tfc_sess.c
>> index 593540da9346..e2ff506ca68d 100644
>> --- a/drivers/target/tcm_fc/tfc_sess.c
>> +++ b/drivers/target/tcm_fc/tfc_sess.c
>> @@ -98,7 +98,7 @@ static void ft_tport_delete(struct ft_tport *tport)
>>
>> /*
>> * Add local port.
>> - * Called thru fc_lport_iterate().
>> + * Called through fc_lport_iterate().
ditto.
>> */
>> void ft_lport_add(struct fc_lport *lport, void *arg)
>> {
>> @@ -110,7 +110,7 @@ void ft_lport_add(struct fc_lport *lport, void *arg)
>>
>> /*
>> * Delete local port.
>> - * Called thru fc_lport_iterate().
>> + * Called through fc_lport_iterate().
ditto.
>> */
>> void ft_lport_del(struct fc_lport *lport, void *arg)
>> {
>> --
>> 2.27.0
All of the other changes look good to me. Thanks.
Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
I.e., it can be merged as is -- up to the maintainer(s).
--
~Randy
