On Wed, Oct 25, 2023 at 05:35:53PM +0200, Hannes Reinecke wrote:
> On 10/25/23 17:11, Benjamin Block wrote:
> > On Mon, Oct 23, 2023 at 11:28:30AM +0200, Hannes Reinecke wrote:
> >> - unsigned tgt_id = cmnd->device->id;
> >> - uint64_t lun_id = cmnd->device->lun;
> >> + unsigned tgt_id = starget->id;
> >> + uint64_t lun_id = 0;
> >
> > Well, hopefully storage targets for LPFC can deal with LUN 0 :)
>
> Sad to say, but it's only with zfcp where I've seen the 'WLUN' thingie
> being deployed. But alright, I'll check if I can grab a valid LUN ID.
I mean, I don't actually know whether this is a problem in practice; sending a
TMF to LUN 0. If this works for the LPFC folks, I don't mind.
> >> - retval = SUCCESS;
> >> - goto out;
> >> - }
> >> + starget_printk(KERN_INFO, starget,
> >> + "Attempting Target Reset!\n");
> >
> > Nitpick: you can remove the line-break.
> >
> Yes, and no. I had been debating with me whether I really wanted
> to do that. Linebreaks are in nearly all of the debugging messages
I meant the line-break in the source-code, not message :)
starget_printk(KERN_INFO, starget, "Attempting Target Reset!\n");
> in this driver, so once I start removing them here questions will
> be asked why I removed it _just_ here, or, why I removed it at all.
>
> I'd prefer doing that in a separate patch.
>
--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vors. Aufs.-R.: Gregor Pillen / Geschäftsführung: David Faller
Sitz der Ges.: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
