Re: [PATCH] aic79xx: fix up NULL command in ahd_done()

[Christoph Hellwig <hch@xxxxxx>]

On Mon, Oct 23, 2023 at 09:30:14AM +0200, Hannes Reinecke wrote:
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
> @@ -1834,7 +1834,7 @@ ahd_done(struct ahd_softc *ahd, struct scb *scb)
>  		} else {
>  			ahd_set_transaction_status(scb, CAM_REQ_CMP);
>  		}
> -	} else if (ahd_get_transaction_status(scb) == CAM_SCSI_STATUS_ERROR) {
> +	} else if (cmd && ahd_get_transaction_status(scb) == CAM_SCSI_STATUS_ERROR) {

Please avoid the overly long line here.

Otherwise looks good.