Hi Muhammad, kernel test robot noticed the following build warnings: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next linus/master v6.6-rc6 next-20231017] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Muhammad-Muzammil/drivers-scsi-lpfc-Fixed-multiple-typos-in-multiple-files/20231017-132518 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next patch link: https://lore.kernel.org/r/20231014115551.8607-1-m.muzzammilashraf%40gmail.com patch subject: [PATCH] drivers: scsi: lpfc: Fixed multiple typos in multiple files config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310172003.DMJaJSon-lkp@xxxxxxxxx/config) compiler: powerpc64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310172003.DMJaJSon-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202310172003.DMJaJSon-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_idiag_cmd_get': drivers/scsi/lpfc/lpfc_debugfs.c:3155:1: error: expected expression before '.' token 3155 | . | ^ >> drivers/scsi/lpfc/lpfc_debugfs.c:3150:16: warning: variable 'bsize' set but not used [-Wunused-but-set-variable] 3150 | size_t bsize; | ^~~~~ vim +/bsize +3150 drivers/scsi/lpfc/lpfc_debugfs.c e2a0a9d69ce224c James Smart 2008-12-04 3119 2a622bfbe1d9566 James Smart 2011-02-16 3120 /* 86a80846a68eeb8 James Smart 2011-04-16 3121 * --------------------------------- 2a622bfbe1d9566 James Smart 2011-02-16 3122 * iDiag debugfs file access methods 86a80846a68eeb8 James Smart 2011-04-16 3123 * --------------------------------- 2a622bfbe1d9566 James Smart 2011-02-16 3124 * 86a80846a68eeb8 James Smart 2011-04-16 3125 * All access methods are through the proper SLI4 PCI function's debugfs 86a80846a68eeb8 James Smart 2011-04-16 3126 * iDiag directory: 2a622bfbe1d9566 James Smart 2011-02-16 3127 * 2a622bfbe1d9566 James Smart 2011-02-16 3128 * /sys/kernel/debug/lpfc/fn<#>/iDiag 2a622bfbe1d9566 James Smart 2011-02-16 3129 */ 2a622bfbe1d9566 James Smart 2011-02-16 3130 2a622bfbe1d9566 James Smart 2011-02-16 3131 /** 2a622bfbe1d9566 James Smart 2011-02-16 3132 * lpfc_idiag_cmd_get - Get and parse idiag debugfs comands from user space 2a622bfbe1d9566 James Smart 2011-02-16 3133 * @buf: The pointer to the user space buffer. 2a622bfbe1d9566 James Smart 2011-02-16 3134 * @nbytes: The number of bytes in the user space buffer. 2a622bfbe1d9566 James Smart 2011-02-16 3135 * @idiag_cmd: pointer to the idiag command struct. 2a622bfbe1d9566 James Smart 2011-02-16 3136 * 2a622bfbe1d9566 James Smart 2011-02-16 3137 * This routine reads data from debugfs user space buffer and parses the 2a622bfbe1d9566 James Smart 2011-02-16 3138 * buffer for getting the idiag command and arguments. The while space in 2a622bfbe1d9566 James Smart 2011-02-16 3139 * between the set of data is used as the parsing separator. 2a622bfbe1d9566 James Smart 2011-02-16 3140 * 2a622bfbe1d9566 James Smart 2011-02-16 3141 * This routine returns 0 when successful, it returns proper error code 2a622bfbe1d9566 James Smart 2011-02-16 3142 * back to the user space in error conditions. 2a622bfbe1d9566 James Smart 2011-02-16 3143 */ 2a622bfbe1d9566 James Smart 2011-02-16 3144 static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes, 2a622bfbe1d9566 James Smart 2011-02-16 3145 struct lpfc_idiag_cmd *idiag_cmd) 2a622bfbe1d9566 James Smart 2011-02-16 3146 { 2a622bfbe1d9566 James Smart 2011-02-16 3147 char mybuf[64]; 2a622bfbe1d9566 James Smart 2011-02-16 3148 char *pbuf, *step_str; b11d48e898de3cb Stephen Boyd 2011-05-12 3149 int i; b11d48e898de3cb Stephen Boyd 2011-05-12 @3150 size_t bsize; 2a622bfbe1d9566 James Smart 2011-02-16 3151 2a622bfbe1d9566 James Smart 2011-02-16 3152 memset(mybuf, 0, sizeof(mybuf)); 2a622bfbe1d9566 James Smart 2011-02-16 3153 memset(idiag_cmd, 0, sizeof(*idiag_cmd)); 2a622bfbe1d9566 James Smart 2011-02-16 3154 bsize = min(nbytes, (sizeof(mybuf)-1)); 46758a53dff3da8 Muhammad Muzammil 2023-10-14 3155 . 2a622bfbe1d9566 James Smart 2011-02-16 3156 if (copy_from_user(mybuf, buf, bsize)) 2a622bfbe1d9566 James Smart 2011-02-16 3157 return -EFAULT; 2a622bfbe1d9566 James Smart 2011-02-16 3158 pbuf = &mybuf[0]; 2a622bfbe1d9566 James Smart 2011-02-16 3159 step_str = strsep(&pbuf, "\t "); 2a622bfbe1d9566 James Smart 2011-02-16 3160 2a622bfbe1d9566 James Smart 2011-02-16 3161 /* The opcode must present */ 2a622bfbe1d9566 James Smart 2011-02-16 3162 if (!step_str) 2a622bfbe1d9566 James Smart 2011-02-16 3163 return -EINVAL; 2a622bfbe1d9566 James Smart 2011-02-16 3164 2a622bfbe1d9566 James Smart 2011-02-16 3165 idiag_cmd->opcode = simple_strtol(step_str, NULL, 0); 2a622bfbe1d9566 James Smart 2011-02-16 3166 if (idiag_cmd->opcode == 0) 2a622bfbe1d9566 James Smart 2011-02-16 3167 return -EINVAL; 2a622bfbe1d9566 James Smart 2011-02-16 3168 2a622bfbe1d9566 James Smart 2011-02-16 3169 for (i = 0; i < LPFC_IDIAG_CMD_DATA_SIZE; i++) { 2a622bfbe1d9566 James Smart 2011-02-16 3170 step_str = strsep(&pbuf, "\t "); 2a622bfbe1d9566 James Smart 2011-02-16 3171 if (!step_str) 86a80846a68eeb8 James Smart 2011-04-16 3172 return i; 2a622bfbe1d9566 James Smart 2011-02-16 3173 idiag_cmd->data[i] = simple_strtol(step_str, NULL, 0); 2a622bfbe1d9566 James Smart 2011-02-16 3174 } 86a80846a68eeb8 James Smart 2011-04-16 3175 return i; 2a622bfbe1d9566 James Smart 2011-02-16 3176 } 2a622bfbe1d9566 James Smart 2011-02-16 3177 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
