On Tue, Oct 17, 2023 at 09:21:45AM +0200, Hannes Reinecke wrote: > (Re-sending as a separate patch:) > When breaking out of a shost_for_each_device() loop one need to do > an explicit scsi_device_put(). And while at it convert to use > shost_priv() instead of a direct reference to ->hostdata. This is still doing two entirely different things. Please send just the trivial scsi_device_put patch as a fix, and the cleanup on top.