On Mon, Oct 16, 2023 at 11:24:21AM +0200, Hannes Reinecke wrote: > Rework scsifront_action_handler() to add the SCSI device as the > first argument, and select between abort and device reset by > checking whether the scsi_cmnd argument is NULL. > > Signed-off-by: Hannes Reinecke <hare@xxxxxxx> > --- > drivers/scsi/xen-scsifront.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c > index a0c13200d53a..26dd229aeb22 100644 > --- a/drivers/scsi/xen-scsifront.c > +++ b/drivers/scsi/xen-scsifront.c > @@ -668,11 +668,11 @@ static int scsifront_queuecommand(struct Scsi_Host *shost, > * We have to wait until an answer is returned. This answer contains the > * result to be returned to the requestor. > */ > -static int scsifront_action_handler(struct scsi_cmnd *sc, uint8_t act) > +static int scsifront_action_handler(struct scsi_device *sdev, struct scsi_cmnd *sc) Please avoid the overly long line here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
