On 10/9/23 15:17, Petr Tesařík wrote: > Hi, (adding James) > > On Wed, 4 Oct 2023 17:58:03 +0900 > Damien Le Moal <dlemoal@xxxxxxxxxx> wrote: > >> Commit ff48b37802e5 ("scsi: Do not attempt to rescan suspended devices") >> modified scsi_rescan_device() to avoid attempting rescanning a suspended >> device. However, the modification added a check to verify that a SCSI >> device is in the running state without checking if the device request >> queue (in the case of block device) is also running, thus allowing the >> exectuion of internal requests. Without checking the device request >> queue, commit ff48b37802e5 fix is incomplete and deadlocks on resume can >> still happen. Use blk_queue_pm_only() to check if the device request >> queue allows executing commands in addition to checking the SCSI device >> state. > > FTR this fix is still needed for rc5. Is there any chance it goes into > fixes before v6.6 is final? The patch is on the scsi list, not for libata. Martin will likely apply it this week. Martin ? Please confirm ! -- Damien Le Moal Western Digital Research