On Fri, Oct 06, 2023 at 02:54:42PM +0200, Milan Broz wrote:
> This patch adds a parameter to use driver_info translation function
> (which will be defined in the following patch).
>
> Only USB storage driver will use it, as other drivers do not need
> more than 32-bit quirk flags.
>
> Signed-off-by: Milan Broz <gmazyland@xxxxxxxxx>
> ---
Apart from the one issue noted below,
Reviewed-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index d1ad6a2509ab..72b48b94aa5f 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -574,7 +574,7 @@ EXPORT_SYMBOL_GPL(usb_stor_adjust_quirks);
>
> /* Get the unusual_devs entries and the string descriptors */
> static int get_device_info(struct us_data *us, const struct usb_device_id *id,
> - const struct us_unusual_dev *unusual_dev)
> + const struct us_unusual_dev *unusual_dev, int fflags_use_index)
> {
> struct usb_device *dev = us->pusb_dev;
> struct usb_interface_descriptor *idesc =
> @@ -590,6 +590,7 @@ static int get_device_info(struct us_data *us, const struct usb_device_id *id,
> idesc->bInterfaceProtocol :
> unusual_dev->useTransport;
> us->fflags = id->driver_info;
> +
> usb_stor_adjust_quirks(us->pusb_dev, &us->fflags);
>
> if (us->fflags & US_FL_IGNORE_DEVICE) {
Extraneous whitespace change. This doesn't belong in the patch.
Alan Stern
