Re: [PATCH 1/7] scsi: Use Scsi_Host as argument for eh_host_reset_handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/3/23 19:33, Bart Van Assche wrote:
On 10/2/23 08:59, Hannes Reinecke wrote:
+    if ((hd = shost_priv(sh)) == NULL){
+        printk(KERN_ERR MYNAM ": host reset: Can't locate host!\n");
          return FAILED;
      }

In the above example and in multiple other cases formatting does not
follow the kernel coding style. Please consider to run git clang-format
HEAD^ on this patch. Otherwise this patch looks good to me.

Will be doing so for the next round.

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux