Hi Wenchao, kernel test robot noticed the following build warnings: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next linus/master v6.6-rc3 next-20230928] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Wenchao-Hao/scsi-core-Add-new-helper-to-iterate-all-devices-of-host/20230928-153648 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next patch link: https://lore.kernel.org/r/20230928073543.3496394-2-haowenchao2%40huawei.com patch subject: [PATCH v2 1/4] scsi: core: Add new helper to iterate all devices of host config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230928/202309281916.qy89onYp-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230928/202309281916.qy89onYp-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309281916.qy89onYp-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/scsi/scsi.c:762: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * helper for shost_for_each_device, see that for documentation vim +762 drivers/scsi/scsi.c 760 761 /** > 762 * helper for shost_for_each_device, see that for documentation 763 * @skip_deleted: if true, sdev in progress of removing would be skipped 764 */ 765 struct scsi_device *__scsi_iterate_devices(struct Scsi_Host *shost, 766 struct scsi_device *prev, 767 bool skip_deleted) 768 { 769 struct list_head *list = (prev ? &prev->siblings : &shost->__devices); 770 struct scsi_device *next = NULL; 771 unsigned long flags; 772 773 spin_lock_irqsave(shost->host_lock, flags); 774 while (list->next != &shost->__devices) { 775 next = list_entry(list->next, struct scsi_device, siblings); 776 /* skip devices that we can't get a reference to */ 777 if (!__scsi_device_get(next, skip_deleted)) 778 break; 779 next = NULL; 780 list = list->next; 781 } 782 spin_unlock_irqrestore(shost->host_lock, flags); 783 784 if (prev) 785 scsi_device_put(prev); 786 return next; 787 } 788 EXPORT_SYMBOL(__scsi_iterate_devices); 789 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
