On Tue, 2023-09-05 at 18:15 -0500, Mike Christie wrote:
> If scsi_execute_cmd returns < 0, it doesn't initialize the sshdr, so
> we
> shouldn't access the sshdr. If it returns 0, then the cmd executed
> successfully, so there is no need to check the sshdr. This has us
> access
> the sshdr when we get a return value > 0.
>
> Signed-off-by: Mike Christie <michael.christie@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>
While all these "fix sshdr use" patches are correct, I start wondering
whether we shouldn't simply execute "
if (sshdr)
sshdr->response_code = 0;
early in scsi_execute_cmd(). That way we could skip all those (ret > 0)
clauses.
Anyway,
Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>
