On Tue, 2023-09-05 at 18:15 -0500, Mike Christie wrote: > If send_mode_select retries scsi_execute_cmd it will leave err set to > SCSI_DH_RETRY/SCSI_DH_IMM_RETRY. If on the retry, the command is > successful, then SCSI_DH_RETRY/SCSI_DH_IMM_RETRY will be returned to > the scsi_dh activation caller. On the retry, we will then detect the > previous MODE SELECT had worked, and so we will return success. > > This patch has us return the correct return value, so we can avoid > the > extra scsi_dh activation call and to avoid failures if the caller had > hit its activation retry limit and does not end up retrying. > > Signed-off-by: Mike Christie <michael.christie@xxxxxxxxxx> Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>
