Hi Christoph, > -----Original Message----- > From: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Sent: Wednesday, September 13, 2023 4:25 PM > To: Nilesh Javali <njavali@xxxxxxxxxxx> > Cc: martin.petersen@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic- > Storage-Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx>; Anil > Gurumurthy <agurumurthy@xxxxxxxxxxx>; Shreyas Deodhar > <sdeodhar@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH v3 1/9] qla2xxx: Add Unsolicited LS Request and > Response Support for NVMe > > External Email > > ---------------------------------------------------------------------- > On Thu, Aug 31, 2023 at 12:44:48AM -0700, Christoph Hellwig wrote: > > Marting, I saw this made it to linux-next now, please revert it. > > qla2xxx hsa absolutely no business changing nvme-fc-driver.h without > > ACKs from the NVMe maintainers. > > .. and it now made it to mainline and causes sparse warnings in the > core nvme-fc and lpfc code. > > Nilesh, Martin, James, can someone please fix this up now? I have posted a fix for this in qla2xxx driver reverting changes done in nvme-fc-driver.h, https://lore.kernel.org/r/20230831112146.32595-1-njavali@xxxxxxxxxxx Thanks, Nilesh