Re: [PATCH v2 1/3] scsi: ufs: core: add wb buffer resize related attr_idn

Bart Van Assche <bvanassche@xxxxxxx> · Fri, 8 Sep 2023 08:31:40 -0700

On 9/8/23 03:20, Lu Hongfei wrote:
UFS4.1 will support the WB buffer resize function, and UFS driver needs
to add definitions for attr_idn related to this function to support
this feature

needs to -> can

Please also mention that the ballot for resizing the WriteBooster buffer 
has been approved.

diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
index 0cced88f4531..8016bf30c8c4 100644
--- a/include/ufs/ufs.h
+++ b/include/ufs/ufs.h
@@ -179,7 +179,10 @@ enum attr_idn {
  	QUERY_ATTR_IDN_WB_BUFF_LIFE_TIME_EST    = 0x1E,
  	QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE        = 0x1F,
  	QUERY_ATTR_IDN_EXT_IID_EN		= 0x2A,
-	QUERY_ATTR_IDN_TIMESTAMP		= 0x30
+	QUERY_ATTR_IDN_TIMESTAMP		= 0x30,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_HINT	= 0x3C,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_EN		= 0x3D,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_STATUS	= 0x3E

Please add a trailing comma after "0x3E".

Thanks,

Bart.







