On Mon, Sep 04, 2023 at 08:48:02AM +0000, Xingui Yang wrote: > We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute > for read-only file, but many of drivers want a helper macro for read-write > file too. > > So we add DEFINE_SHOW_STORE_ATTRIBUTE helper to reduce duplicated code. > > Signed-off-by: Luo Jiaxing <luojiaxing@xxxxxxxxxx> I believe you need to preserve Luo's authorship. Perhaps, Co-developed-by: Xingui ... (depending if you really do some job in the certain patch(es) or not). > Signed-off-by: Xingui Yang <yangxingui@xxxxxxxxxx> Code wise LGTM, FWIW, Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko
