Re: [PATCH] scsi: ufs: Fix the build for big endian 32-bit ARM systems

[Bart Van Assche <bvanassche@xxxxxxx>]

On 8/27/23 17:28, Arnd Bergmann wrote:
> The fix makes sense, but I think the description is wrong:
> The weird struct padding on Arm randconfig builds happens
> with CONFIG_AEABI disabled (implying the old OABI),
> regardless of CONFIG_CPU_BIG_ENDIAN.

Thanks for the feedback. I will update the patch description.

> > -			union {
> > -				__u8 tm_function;
> > -				__u8 query_function;
> > -			};
> > +			__u8 tm_or_query_function;
> >   			__u8 response;
>
> The problem on OABI is that any struct or union is word
> aligned. I would assume that marking the union as __packed
> also addresses the problem here, but I have not tested that
> and your patch seems fine.

Marking the union as __packed seems to be sufficient. I prefer that
approach because I would like to keep the union. I will post a second
version of this patch.

Thanks,

Bart.