On Mon, Aug 28, 2023 at 3:25 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > clang-18 has improved its support for detecting operations that will > truncate values at runtime via -wfortify-source resulting in two new ^ -Wfortify-source > warnings (or errors with CONFIG_WERROR=y): > > drivers/scsi/myrb.c:1906:10: warning: 'snprintf' will always be > truncated; specified size is 32, but format string expands to at least > 34 [-Wfortify-source] > > drivers/scsi/myrs.c:1089:10: warning: 'snprintf' will always be > truncated; specified size is 32, but format string expands to at least > 34 [-Wfortify-source] > > When we have a string literal that does not contain any format flags, > rather than use snprintf (sometimes with a size that's too small), let's > use sprintf. Even better, Ard points out this could be strcpy (or one of the variants). Will send a v2 tomorrow. > > This is pattern is cleaned up throughout two files. > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > --- > Nick Desaulniers (2): > scsi: myrb: fix -Wfortify-source > scsi: myrs: fix -Wfortify-source > > drivers/scsi/myrb.c | 8 ++++---- > drivers/scsi/myrs.c | 14 +++++++------- > 2 files changed, 11 insertions(+), 11 deletions(-) > --- > base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c > change-id: 20230828-scsi_fortify-9f8d279bf9aa > > Best regards, > -- > Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > -- Thanks, ~Nick Desaulniers
