On 8/22/23 05:40, Bart Van Assche wrote: > Most callers of scsi_rescan_device() have the scsi_device pointer s/Most/All ? If it is most, then you have an issue somewhere :) > available. Pass a struct scsi_device pointer to scsi_rescan_device() > instead of a struct device pointer. This change prevents that a > pointer to another struct device pointer would be passed accidentally to ...pointer to another struct device to be passed accidentally to... > scsi_rescan_device(). > > Remove the scsi_rescan_device() declaration from the scsi_priv.h header > file since it duplicates the declaration in <scsi/scsi_host.h>. With the above nits fixed, feel free to add: Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> -- Damien Le Moal Western Digital Research
