Re: [PATCH v2] scsi: ufs: ufs-qcom: clear qunipro_g4_sel for HW major version > 5

To: Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>, Manivannan Sadhasivam <mani@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH v2] scsi: ufs: ufs-qcom: clear qunipro_g4_sel for HW major version > 5
From: "Bao D. Nguyen" <quic_nguyenb@xxxxxxxxxxx>
Date: Mon, 21 Aug 2023 07:08:58 -0700
Cc: <linux-arm-msm@xxxxxxxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Nitin Rawat <quic_nitirawa@xxxxxxxxxxx>
In-reply-to: <20230821-topic-sm8x50-upstream-ufs-major-5-plus-v2-1-f42a4b712e58@linaro.org>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 8/21/2023 5:11 AM, Neil Armstrong wrote:

The qunipro_g4_sel clear is also needed for new platforms with
major version > 5, fix the version check to take this in account.

Change "version > 5, fix.." to "version > 5. Fix..."
"into account."? Anyway..

Reviewed-by: Bao D. Nguyen <quic_nguyenb@xxxxxxxxxxx>

References:
- [PATCH v2] scsi: ufs: ufs-qcom: clear qunipro_g4_sel for HW major version > 5
  - From: Neil Armstrong