On 21/08/2023 12:38, Manivannan Sadhasivam wrote:
On Mon, Aug 21, 2023 at 09:41:54AM +0200, Neil Armstrong wrote:
The qunipro_g4_sel clear is also needed for new platforms with
major version > 5, fix the version check to take this in account.
Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
This is a fix, isn't it? With the fixes tag for 9c02aa24bf40,
It could be considered as a fix yes, I'll resent a v2 with suc tag and Acks.
Thanks,
Neil
Acked-by: Manivannan Sadhasivam <mani@xxxxxxxxxx>
- Mani
---
drivers/ufs/host/ufs-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index f88febb23123..d1149b1c3ed5 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -365,7 +365,7 @@ static void ufs_qcom_select_unipro_mode(struct ufs_qcom_host *host)
ufs_qcom_cap_qunipro(host) ? QUNIPRO_SEL : 0,
REG_UFS_CFG1);
- if (host->hw_ver.major == 0x05)
+ if (host->hw_ver.major >= 0x05)
ufshcd_rmwl(host->hba, QUNIPRO_G4_SEL, 0, REG_UFS_CFG0);
/* make sure above configuration is applied before we return */
---
base-commit: 47d9bb711707d15b19fad18c8e2b4b027a264a3a
change-id: 20230821-topic-sm8x50-upstream-ufs-major-5-plus-4eaad3f3d857
Best regards,
--
Neil Armstrong <neil.armstrong@xxxxxxxxxx>
