On 2023/08/18 6:41, Igor Pylypiv wrote:
> For Command Duration Limits policy 0xD (command completes without
> an error) libata needs FIS in order to detect the ATA_SENSE bit and
> read the Sense Data for Successful NCQ Commands log (0Fh).
>
> Set return_fis_on_success for commands that have a CDL descriptor
> since any CDL descriptor can be configured with policy 0xD.
>
> Signed-off-by: Igor Pylypiv <ipylypiv@xxxxxxxxxx>
> ---
> drivers/scsi/libsas/sas_ata.c | 3 +++
> include/scsi/libsas.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 77714a495cbb..da67c4f671b2 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -207,6 +207,9 @@ static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc)
> task->ata_task.use_ncq = ata_is_ncq(qc->tf.protocol);
> task->ata_task.dma_xfer = ata_is_dma(qc->tf.protocol);
>
> + /* CDL policy 0xD requires FIS for successful (no error) completions */
> + task->ata_task.return_fis_on_success = ata_qc_has_cdl(qc);
>From the comments on patch 1, this should be:
if (qc->flags & ATA_QCFLAG_HAS_CDL)
task->ata_task.return_sdb_fis_on_success = 1;
Note the renaming to "return_sdb_fis_on_success" to be clear about the FIS type.
> +
> if (qc->scsicmd)
> ASSIGN_SAS_TASK(qc->scsicmd, task);
>
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index 159823e0afbf..9e2c69c13dd3 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -550,6 +550,7 @@ struct sas_ata_task {
> u8 use_ncq:1;
> u8 set_affil_pol:1;
> u8 stp_affil_pol:1;
> + u8 return_fis_on_success:1;
>
> u8 device_control_reg_update:1;
>
--
Damien Le Moal
Western Digital Research
