On 2023/08/18 6:41, Igor Pylypiv wrote:
> Introduce the inline helper function ata_qc_has_cdl() to test if
> a queued command has a Command Duration Limits descriptor set.
>
> Signed-off-by: Igor Pylypiv <ipylypiv@xxxxxxxxxx>
> ---
> include/linux/libata.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 820f7a3a2749..bc7870f1f527 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -1062,6 +1062,11 @@ static inline bool ata_port_is_frozen(const struct ata_port *ap)
> return ap->pflags & ATA_PFLAG_FROZEN;
> }
>
> +static inline bool ata_qc_has_cdl(struct ata_queued_cmd *qc)
> +{
> + return qc->flags & ATA_QCFLAG_HAS_CDL;
> +}
This is used in one place only in patch 3, and the only other place we test this
flag is in ata_build_rw_tf(). So I do not think this is necessary. Let's drop this.
> +
> extern int ata_std_prereset(struct ata_link *link, unsigned long deadline);
> extern int ata_wait_after_reset(struct ata_link *link, unsigned long deadline,
> int (*check_ready)(struct ata_link *link));
--
Damien Le Moal
Western Digital Research
