Re: isd200.c Has fatal bugs and is probably not used any more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 21 Aug 2007 22:06:26 +0300, Boaz Harrosh wrote:
> Hi!
> 
> the driver drivers/usb/storage/isd200.c has code like:
> 
> static int isd200_action( struct us_data *us, int action,
>               void* pointer, int value )
> 
> ...
> 
>     case ACTION_READ_STATUS:
>         US_DEBUGP("   isd200_action(READ_STATUS)\n");
>         ata.generic.ActionSelect = ACTION_SELECT_0|ACTION_SELECT_2;
>         ata.generic.RegisterSelect =
>           REG_CYLINDER_LOW | REG_CYLINDER_HIGH |
>           REG_STATUS | REG_ERROR;
>         srb->sc_data_direction = DMA_FROM_DEVICE;
>         srb->request_buffer = pointer;
>         srb->request_bufflen = value;
>         break;
> ...
> 
> Now what the hell is that hijacked scsi_cmnd and who said
> that the srb->use_sg is Zero. If this is a regular queued
> scsi_cmnd, this can easily crash. And at best a memory leak.
> 
> The last git recorded real change to this driver was it's insertion
> into git by Linus.
> 
> Is this an indication that this driver is no longer used and
> can be removed?

All IBM bladecenters have the HW this driver supports.  And it does
mostly work.  This particular frag requires USB_DEBUG enabled, correct?




-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux