Saurav, please rework this patch and add the missing description. It would also be good to consolidate some of the repeated
tasks into one or two sub-routines.
Please publish a v2 patch series.
/John
On 7/21/23 13:48, Jerry Snitselaar wrote:
On Fri, Jul 21, 2023 at 07:58:26AM -0700, Bart Van Assche wrote:
On 7/21/23 03:23, Saurav Kashyap wrote:
From: Jerry Snitselar <jsnitsel@xxxxxxxxxx>
[ ... ]
Signed-off-by: Jerry Snitselar <jsnitsel@xxxxxxxxxx>
Has Jerry's name changed or has his name been misspelled? I think
a letter 'a' is missing from his name.
No, and yes. :)
This was originally passed along in a bugzilla bug as an example of a
possible solution, but I didn't figure it would be the final patch.
The original patch had the following summary and description above
the stack trace:
scsi: bnx2fc: Don't use dma_*_coherent for session resources
With commit f5ff79fddf0e ("dma-mapping: remove CONFIG_DMA_REMAP") a
crash can be seen with bnx2fc, because dma_free_coherent can not be
called in an interrupt context. Replace the dma_*_coherent code in
bnx2fc_alloc_session_resc and bnx2fc_free_session_resc, with kzalloc +
dma_map_single, and kfree + dma_unmap_single calls. Also properly
unwind in the error path for bnx2fc_alloc_session_resc, cleaning up
what it did succeed in allocating and mapping. This deals with seeing
the following panic:
Regards,
Jerry
Bart.
