On Mon, 20 Aug 2007 09:10:31 +0200 Jens Axboe <jens.axboe@xxxxxxxxxx> wrote: > On Sat, Aug 18 2007, FUJITA Tomonori wrote: > > On Fri, 17 Aug 2007 01:47:59 +0900 > > FUJITA Tomonori <tomof@xxxxxxx> wrote: > > > > > This is for Jens' sglist branch in the block git tree. > > > > > > It enables sg chaining support for the LLDs that use scsi_for_each_sg > > > accessor properly. > > > > > > --- > > > >From a6e50a3b476bc193de103e8c1d95877ced38918e Mon Sep 17 00:00:00 2001 > > > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > > > Date: Fri, 17 Aug 2007 01:35:41 +0900 > > > Subject: [PATCH] add use_sg_chaining option to scsi_host_template > > > > > > This option is true if a low-level driver can support sg > > > chaining. This will be removed eventually when all the drivers are > > > converted to support sg chaining. q->max_phys_segments is set to > > > SCSI_MAX_SG_SEGMENTS if false. > > > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > > > --- > > > arch/ia64/hp/sim/simscsi.c | 1 + > > > drivers/scsi/3w-9xxx.c | 1 + > > > drivers/scsi/3w-xxxx.c | 1 + > > > drivers/scsi/BusLogic.c | 1 + > > > drivers/scsi/NCR53c406a.c | 3 ++- > > > drivers/scsi/a100u2w.c | 1 + > > > drivers/scsi/aacraid/linit.c | 1 + > > > drivers/scsi/aha1740.c | 1 + > > > drivers/scsi/aic7xxx/aic79xx_osm.c | 1 + > > > drivers/scsi/aic7xxx/aic7xxx_osm.c | 1 + > > > drivers/scsi/aic7xxx_old.c | 1 + > > > drivers/scsi/arcmsr/arcmsr_hba.c | 1 + > > > drivers/scsi/dc395x.c | 1 + > > > drivers/scsi/dpt_i2o.c | 1 + > > > drivers/scsi/eata.c | 3 ++- > > > drivers/scsi/hosts.c | 1 + > > > drivers/scsi/hptiop.c | 1 + > > > drivers/scsi/ibmmca.c | 1 + > > > drivers/scsi/ibmvscsi/ibmvscsi.c | 1 + > > > drivers/scsi/initio.c | 1 + > > > drivers/scsi/ipr.c | 1 + > > > > I should have dropped ipr since we haven't converted libata yet. > > But we have, are there still bits missing? I'm just a bit nervous about possible bugs. Probably we need to remove blk_queue_max_phys_segments() in libata for a possible lower sg list size (< 128). BTW, I think that it would be good to test the sglist with a lower sg list size (like 32) to test all the llds. diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index d23a181..01a0197 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -795,8 +795,6 @@ int ata_scsi_slave_config(struct scsi_device *sdev) ata_scsi_sdev_config(sdev); - blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD); - sdev->manage_start_stop = 1; if (dev) - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
