Re: [EXT] Re: [PATCH v2 07/10] qla2xxx: Observed call trace in smp_processor_id()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/08/2023 12:22, Nilesh Javali wrote:
So isn't something like
queue_work_on(raw_smp_processor_id(), ha->wq, &qpair->q_work) same as
queue_work(ha->wq, &qpair->q_work)?

I see that queue_work() already has the raw_smp_processor_id() call.
In fact queue_work uses queue_work_on that has raw_smp_processor_id.
So, qla2x using queue_work_on with raw_smp_processor_id should be okay,

Using queue_work(), rather than queue_work_on() with raw_smp_processor_id(), would be simpler. Simpler is generally better. And I see no advantage in using queue_work_on() with raw_smp_processor_id() (over queue_work()).

Thanks,
John



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux