On 8/9/23 18:36, Damien Le Moal wrote:
On 8/10/23 05:23, Bart Van Assche wrote:
+static bool dd_use_zone_write_locking(struct request_queue *q)
+{
+ return q->limits.use_zone_write_lock && blk_queue_is_zoned(q);
use_zone_write_lock should be true ONLY if the queue is zoned.
So the "&& blk_queue_is_zoned(q)" seems unnecessary to me.
This little helper could be moved to be generic in blkdev.h too.
Hi Damien,
use_zone_write_lock should be set by the block driver (e.g. a SCSI
LLD) before I/O starts. The zone model information is retrieved by
submitting I/O. It is not clear to me how to set use_zone_write_lock
to true only for zoned block devices before I/O starts since I/O is
required to retrieve information about the zone model.
Thanks,
Bart.