> -----Original Message----- > From: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Sent: Wednesday, August 9, 2023 7:12 PM > To: Nilesh Javali <njavali@xxxxxxxxxxx> > Cc: martin.petersen@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic- > Storage-Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx>; Anil > Gurumurthy <agurumurthy@xxxxxxxxxxx>; Shreyas Deodhar > <sdeodhar@xxxxxxxxxxx> > Subject: Re: [PATCH v2 01/10] qla2xxx: Add NVMe Disconnect support > > I don't see how this could go in through a driver pull request. You first need > to convince the nvme maintainers that disconnect support is a good idea and > actually support it properly in the nvme core. The patch is not specific to the NVME disconnect feature, but rather focuses on adding infrastructure to the qla2xxx driver to pass-up unsolicited received FC-NVMe Link Service (LS) request to the transport via nvme_fc_rcv_ls_req(). And to complete the LS response via xmt_ls_rsp() to the firmware using FC-NVMe Link Service Pass-Through IOCB. The current commit message is misleading, as the code does not entail any changes specific to NVMe disconnect. Would it be acceptable to resubmit this patch with a new commit message stating, "Adding support for unsolicited LS request and response". Thanks, Manish
