Hi Martin, On Tue, Aug 8, 2023 at 8:07 AM Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote: > > > Hi Ranjan! > > >> This HW bug impacts only a few registers. However, for code > >> simplicity, we added retry logic(of 3 retries count) for all > >> registers exposed to the driver. > > > Now the recommendation is: > > - Increase retry count from 3 to 30 for only impacted registers. > > - We also do not want to reduce the retries from 3 to 1 for > > non-impacted registers to avoid any regression. > > > > Hence, this patch retries upto 30 times for impacted registers and 3 > > times for non-impacted registers. > > What is the adverse affect is of having a loop iterator of 30 if the > non-impacted registers always return a non-zero value after 1 to 3 > attempts? >For non-impacted registers where zero is invalid, the driver will always get non-zero value in 1/3 attempts. So no concerns with 30 retries with those registers. But for few registers zero may be a valid value and we don’t want those registers to get penalized with 30 read retries where 1/3 reads would have sufficed. Thanks & Regards, Ranjan > -- > Martin K. Petersen Oracle Linux Engineering
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
