Re: [PATCH] scsi: ufs: Fix the build for gcc 9 and before

Bart Van Assche <bvanassche@xxxxxxx> · Tue, 1 Aug 2023 16:23:22 -0700

On 8/1/23 14:52, Nathan Chancellor wrote:
On Tue, Aug 01, 2023 at 01:13:23PM -0700, Bart Van Assche wrote:
  static void ufshcd_check_header_layout(void)
  {
+#if defined(__GNUC__) && __GNUC__ -0 < 10

clang defines __GNUC__ and it does not sound like it is impacted by this
issue? I just built with LLVM 11 through 17 and did not see it. Can this
be made more specific?

Also, can we use IS_ENABLED() and not rely on the preprocessor? This
appears to work for me.

     if (IS_ENABLED(CONFIG_CC_IS_GCC) && CONFIG_GCC_VERSION < 100000)
         return;

Thanks for the feedback. A new version of this patch has been posted.

Bart.