From: Matthew Wilcox <matthew@xxxxxx>
Date: Wed, 15 Aug 2007 11:26:00 -0600
> On Tue, Aug 07, 2007 at 12:26:04AM -0700, David Miller wrote:
> > > - struct sbus_dma *dma;
> > > + union {
> > > + struct sbus_dma *sbus_dma;
> > > + unsigned int x86_dma;
> > > + };
> > > };
> >
> > Feel free to make this a "void *dma_cookie" or similar.
> > It's private to the bus front-end.
>
> Hi Dave,
>
> Could I just clarify; would you prefer it to be a void *? I prefer the
> anonymous union that I have there right now, but I'm not particularly
> attached to it. In particular, I don't really care to be casting ints
> (x86) to pointers, but that's a matter of personal taste.
Alternatively, you could remove this member entirely, and
make the front-end driver allocate a private area at the
end of "struct esp" to use for whatever purpose it likes.
I'm mostly ambivalent, but if the member stays it should be
some generic type rather than anything front-end specific
like it is now.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
