On 2023/7/31 10:05, Damien Le Moal wrote:
On 7/31/23 10:44, Jason Yan wrote:
Hi Wenchao,
On 2023/7/29 18:24, Wenchao Hao wrote:
sas_queue_reset is always called with param "wait" set to 0, so
remove it from this function's param list. And remove unused
function sas_wait_eh.
I did not find any users passing '1' to sas_queue_reset() in the git
history. It seems it is never used. So It's ok to remove it, I guess.
Just one nit, there should be a blank between "scsi:" and "libsas" in
the subject:
scsi: libsas: Simplify sas_queue_reset and remove unused code
Otherwise looks good to me:
Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>
Yeah, code wise, it looks good.
However, I am seeing issues with completions for commands that use command
duration limits. There are some unusual completions that needs special handling
with CDL (e.g. some aborted commands can be notified with a success and
sense-data-available-bit set. For these, we kick libata-EH but it seems that
this is not well working with libsas. So I wonder if this code may need to be
used for CDL... So let's please hold on before applying this. Let me check the
CDL issues I am seeing first.
Sure. It's just a cleanup. Let's hold on until it is confirmed.
Thanks,
Jason
