On Wed, 15 Aug 2007 11:35:49 -0500 James Bottomley <James.Bottomley@xxxxxxxxxxxx> wrote:
> On Fri, 2007-08-10 at 14:50 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > From: Gabriel C <nix.or.die@xxxxxxxxxxxxxx>
> >
> > I get this warnings on current git when CONFIG_PCI is not set :
> >
> > drivers/scsi/fdomain.c:390: warning: 'PCI_dev' defined but not used
> > drivers/scsi/fdomain.c:1768: warning: 'fdomain_pci_tbl' defined but not used
> >
> > Signed-off-by: Gabriel Craciunescu <nix.or.die@xxxxxxxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> This function looks decidedly dangerous since it references a
> non-existent variable when CONFIG_PCI isn't set. It seems to work
> because pci_dev_put() is defined to a null macro, but it's not safe:
>
> static int fdomain_16x0_release(struct Scsi_Host *shpnt)
> {
> if (shpnt->irq)
> free_irq(shpnt->irq, shpnt);
> if (shpnt->io_port && shpnt->n_io_port)
> release_region(shpnt->io_port, shpnt->n_io_port);
> if (PCI_bus)
> pci_dev_put(PCI_dev);
> return 0;
> }
>
I expect that's why pci_dev_put() is still implemented as a macro.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
