Re: [PATCH] qedf: Changed string copy method for "stop_io_on_error" from sprintf to put_user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On středa 26. července 2023 12:55:52 CEST Johannes Thumshirn wrote:
> On 26.07.23 12:12, Saurav Kashyap wrote:
> 
> That one seems to be a duplicate of:
> 
> https://lore.kernel.org/linux-scsi/20230724120241.40495-2-oleksandr@xxxxxxxxxx/
> 
> Which looks IMHO way nicer than the put_user() calls.

Thanks for checking that submission. Yes, I'd appreciate some reaction on it as a) open-coding what can be done with a simple simple_read_from_buffer() is a questionable decision; and b) there are two more places where the same issue occurs, and the RFC I posted should fix those too.

> Regards,
> 
>      Johannes
> 
> 


-- 
Oleksandr Natalenko (post-factum)
Principal Software Maintenance Engineer

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux