Re: [PATCH] scsi: pm80xx: fix error return code in pm8001_pci_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 25, 2023 at 08:57:06PM +0800, Yang Yingliang wrote:
> If pm8001_init_sas_add() fails, return error code in pm8001_pci_probe().
> 
> Fixes: 14a8f116cdc0 ("scsi: pm80xx: Add GET_NVMD timeout during probe")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Reviewed-by: Igor Pylypiv <ipylypiv@xxxxxxxxxx>

> ---
>  drivers/scsi/pm8001/pm8001_init.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 2e886c1d867d..4995e1ef4e0e 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -1181,7 +1181,8 @@ static int pm8001_pci_probe(struct pci_dev *pdev,
>  		pm80xx_set_thermal_config(pm8001_ha);
>  	}
>  
> -	if (pm8001_init_sas_add(pm8001_ha))
> +	rc = pm8001_init_sas_add(pm8001_ha);
> +	if (rc)
>  		goto err_out_shost;
>  	/* phy setting support for motherboard controller */
>  	rc = pm8001_configure_phy_settings(pm8001_ha);
> -- 
> 2.25.1
> 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux