Re: [PATCH v3 1/9] ata: remove reference to non-existing error_handler()

John Garry <john.g.garry@xxxxxxxxxx> · Tue, 25 Jul 2023 12:09:11 +0100

On 21/07/2023 17:32, Niklas Cassel wrote:

Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>

diff --git a/include/linux/libata.h b/include/linux/libata.h
index 820f7a3a2749..3eeea76c30de 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1785,7 +1785,7 @@ static inline struct ata_queued_cmd *ata_qc_from_tag(struct ata_port *ap,
  {
  	struct ata_queued_cmd *qc = __ata_qc_from_tag(ap, tag);
  
-	if (unlikely(!qc) || !ap->ops->error_handler)
+	if (unlikely(!qc))
  		return qc;

nit: It might be better to explicitly return 'NULL' here. Or maybe 
combine with "if ((qc->flags & (ATA_QCFLAG_ACTIVE" check to have only 1x 
point where we return NULL, like

if (!qc || (qc->flags & (ATA_QCFLAG_ACTIVE ...
	retrun NULL;
return qc;

  
  	if ((qc->flags & (ATA_QCFLAG_ACTIVE |
--







