Re: [PATCH v10 02/33] scsi: Allow passthrough to override what errors to retry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/17/23 11:59 AM, Bart Van Assche wrote:
> On 7/14/23 14:33, Mike Christie wrote:
>> diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
>> index 526def14e7fb..9a3908614dc9 100644
>> --- a/include/scsi/scsi_cmnd.h
>> +++ b/include/scsi/scsi_cmnd.h
>> @@ -71,6 +71,23 @@ enum scsi_cmnd_submitter {
>>       SUBMITTED_BY_SCSI_RESET_IOCTL = 2,
>>   } __packed;
>>   +#define SCMD_FAILURE_RESULT_ANY    0x7fffffff
>> +#define SCMD_FAILURE_STAT_ANY    0xff
>> +#define SCMD_FAILURE_SENSE_ANY    0xff
>> +#define SCMD_FAILURE_ASC_ANY    0xff
>> +#define SCMD_FAILURE_ASCQ_ANY    0xff
>> +#define SCMD_FAILURE_NO_LIMIT    -1
> 
> A comment that explains the meaning of SCMD_FAILURE_RESULT_ANY and
> SCMD_FAILURE_NO_LIMIT would be welcome. Does SCMD_FAILURE_RESULT_ANY e.g. retry only negative values of scmd->result, only positive or both?

The retries in this patchset are only for when result > 0.

> 
> I assume that SCMD_FAILURE_NO_LIMIT means that there is no limit on the number of retries?
> 

Yes.

Will add some comments.

> Thanks,
> 
> Bart.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux