On Thu, Jul 13, 2023 at 02:11:23PM +0100, Sudeep Holla wrote: > On Wed, Jul 12, 2023 at 02:48:32PM +0800, Yang Li wrote: > > There is no need to call the dev_err() function directly to print a > > custom message when handling an error from either the platform_get_irq() > > or platform_get_irq_byname() functions as both are going to display an > > appropriate error message in case of a failure. > > > > ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error > > > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 > > Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx> > Sorry for this, I didn't mean to ack this patch, no idea how on earth I managed to do that (must be some wrong key combination in my email client) but I wanted and meant to ack only this [1]. Sorry for the noise. -- Regards, Sudeep [1] https://lore.kernel.org/r/20230712062853.11007-9-frank.li@xxxxxxxx