Re: [PATCH v3 2/4] scsi: ufs: Fix handling of lrbp->cmd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



@@ -5408,7 +5406,6 @@ static void ufshcd_release_scsi_cmd(struct ufs_hba *hba,
 	struct scsi_cmnd *cmd = lrbp->cmd;
 
 	scsi_dma_unmap(cmd);
-	lrbp->cmd = NULL;	/* Mark the command as completed. */
 	ufshcd_release(hba);
 	ufshcd_clk_scaling_update_busy(hba);
 }

Hi,
Is there any reason to delete "lrbp->cmd = NULL"?
As far as I know, clear to NULL to indicate that cmd is completed.

When the UFS MCQ mode is activated, check that lrbp->cmd is NULL to check the completion of the command.
https://lore.kernel.org/linux-scsi/f0d923ee1f009f171a55c258d044e814ec0917ab.1685396241.git.quic_nguyenb@xxxxxxxxxxx/

If there is no special reason, why don't you add "lrb->cmd = NULL" again?






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux