> On Jun 7, 2023, at 4:38 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
>
> From: Shreyas Deodhar <sdeodhar@xxxxxxxxxxx>
>
> Klocwork tool reported pointer 'rport' returned
> from call to function 'fc_bsg_to_rport' may be
> NULL and will be dereferenced.
>
> Add a fix to validate rport before dereferencing.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Shreyas Deodhar <sdeodhar@xxxxxxxxxxx>
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index c928b27061a9..19bb64bdd88b 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -2996,6 +2996,8 @@ qla24xx_bsg_request(struct bsg_job *bsg_job)
>
> if (bsg_request->msgcode == FC_BSG_RPT_ELS) {
> rport = fc_bsg_to_rport(bsg_job);
> + if (!rport)
> + return ret;
> host = rport_to_shost(rport);
> vha = shost_priv(host);
> } else {
> --
> 2.23.1
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
