> On Jun 7, 2023, at 4:38 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
>
> Klocwork reported warning of rport maybe NULL
> and will be dereferenced.
> rport returned by call to fc_bsg_to_rport could
> be NULL and dereferenced.
>
> Check valid rport returned by fc_bsg_to_rport.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index dba7bba788d7..c928b27061a9 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -283,6 +283,10 @@ qla2x00_process_els(struct bsg_job *bsg_job)
>
> if (bsg_request->msgcode == FC_BSG_RPT_ELS) {
> rport = fc_bsg_to_rport(bsg_job);
> + if (!rport) {
> + rval = -ENOMEM;
> + goto done;
> + }
> fcport = *(fc_port_t **) rport->dd_data;
> host = rport_to_shost(rport);
> vha = shost_priv(host);
> --
> 2.23.1
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
