> +scsi_block_targets(struct device *dev, struct Scsi_Host *shost) I think the logical argument order would be to pass the shost first. > -extern void scsi_target_block(struct device *); > +extern void scsi_block_targets(struct device *dev, struct Scsi_Host *shost); And please drop the pointless extern here. With that: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
