On Wed, Jun 07, 2023 at 08:22:48PM +0200, mwilck@xxxxxxxx wrote: > From: Martin Wilck <mwilck@xxxxxxxx> > > All callers (fc_remote_port_delete(), __iscsi_block_session(), > __srp_start_tl_fail_timers(), srp_reconnect_rport(), snic_tgt_del()) pass > parent devices of scsi_target devices to scsi_target_block(). > Simplify scsi_target_block() to assume that it is always passed a parent > device. Btw, one thing I realized is that the function has been a bit misnamed for a while, and becomes even more so now. Maybe scsi_block_targets is a better name as it blocks all the targets hanging off the passed in devices as children?