RE: [PATCH v2 3/3] ufs: poll pmc until another pa request is completed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> A change history like the above should either occur below the "---"
> separator or in a cover letter instead of in the patch description.
> 
> > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> [ ... ]

Thanks for your information.

> 
> There are two changes in this patch: the introduction of the
> __ufshcd_poll_uic_pwr() helper function and also the introduction of a
> wait loop. Please split this patch into two patches - one patch that
> introduces the helper function and a second patch that introduces the wait
> loop. That will make this patch series easier to review.
> 
> Thanks,
> 
> Bart.

I got it and I have one question.

The reason why I bound all the three things is
because I thought they were tangled each other. I felt that the first patch relies
on both the second one and the third one and the helper named __ufshcd_poll_uic_pwr
in the third one calls ufshcd_ready_for_uic_cmd where the change of the second one is applied.
So I thought I should care this sort of conflict in terms of the driver's working.
Don't submitters need to care this?

Thanks.
Kiwoong Kim






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux