> On 5/31/23 15:40, Bart Van Assche wrote: > > ufshcd_add_command_trace() traces SCSI commands. Remove a > > ufshcd_add_command_trace() call from a code path that is not related to > > SCSI commands. > > > > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> Reviewed-by: Avri Altman <avri.altman@xxxxxxx> > > --- > > drivers/ufs/core/ufshcd.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > > index 0856f01b761d..1f7a4ec211ff 100644 > > --- a/drivers/ufs/core/ufshcd.c > > +++ b/drivers/ufs/core/ufshcd.c > > @@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, > int task_tag, > > lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) { > > if (hba->dev_cmd.complete) { > > hba->dev_cmd.cqe = cqe; > > - ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP); > > complete(hba->dev_cmd.complete); > > ufshcd_clk_scaling_update_busy(hba); > > } > > Can anyone please help with reviewing this patch? > > Thanks, > > Bart.