On 6/1/23 19:39, Randy Dunlap wrote:
When RESET_CONTROLLER is not set, kconfig complains about missing
dependencies for RESET_TI_SYSCON, so add the missing dependency
just as is done above for SCSI_UFS_QCOM.
Silences this kconfig warning:
WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
Selected by [m]:
- SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]
Fixes: de48898d0cb6 ("scsi: ufs-mediatek: Create reset control device_link")
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Link: lore.kernel.org/r/202306020859.1wHg9AaT-lkp@xxxxxxxxx
Cc: Stanley Chu <stanley.chu@xxxxxxxxxxxx>
Cc: Peter Wang <peter.wang@xxxxxxxxxxxx>
Cc: Paul Gazzillo <paul@xxxxxxxxx>
Cc: Necip Fazil Yildiran <fazilyildiran@xxxxxxxxx>
Cc: linux-scsi@xxxxxxxxxxxxxxx
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
---
drivers/ufs/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
--- a/drivers/ufs/host/Kconfig
+++ b/drivers/ufs/host/Kconfig
@@ -72,6 +72,7 @@ config SCSI_UFS_QCOM
config SCSI_UFS_MEDIATEK
tristate "Mediatek specific hooks to UFS controller platform driver"
depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
+ depends on RESET_CONTROLLER
select PHY_MTK_UFS
select RESET_TI_SYSCON
help
Hmm ... is the above patch complete? Shouldn't a similar dependency be
added to the ufs-hisi and ufs-sprd drivers? See also the following git
grep output:
$ git grep -nH 'include.*linux/reset.h' */ufs
drivers/ufs/host/ufs-hisi.c:16:#include <linux/reset.h>
drivers/ufs/host/ufs-mediatek.c:21:#include <linux/reset.h>
drivers/ufs/host/ufs-qcom.h:9:#include <linux/reset.h>
drivers/ufs/host/ufs-sprd.c:14:#include <linux/reset.h>
Thanks,
Bart.
