On Wed, Jun 07, 2023 at 07:05:34AM -0700, Bart Van Assche wrote: >> The reason is simple: I wasn't certain if dev_to_shost() could return >> NULL, and preferred skipping the wait over an Oops. I hear you say that >> dev_to_shost() can't go wrong, so I'll remove the NULL test. > > I propose to pass shost as the first argument to scsi_target_block() > instead of using dev_to_shost() inside scsi_target_block(). Except in > __iscsi_block_session(), shost is already available as a local variable. That sounds like a good idea to me.
