On 05.06.23 12:53, Damien Le Moal wrote: > In ata_scsi_dev_config(), instead of hard-coding the test to check if > an ATA device supports NCQ by looking at the ATA_DFLAG_NCQ flag, use > ata_ncq_supported(). > > Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > Reviewed-by: Hannes Reinecke <hare@xxxxxxx> > --- > drivers/ata/libata-scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index 7bb12deab70c..9e79998e3958 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c > @@ -1122,7 +1122,7 @@ int ata_scsi_dev_config(struct scsi_device *sdev, struct ata_device *dev) > if (dev->flags & ATA_DFLAG_AN) > set_bit(SDEV_EVT_MEDIA_CHANGE, sdev->supported_events); > > - if (dev->flags & ATA_DFLAG_NCQ) > + if (ata_ncq_supported(dev)) > depth = min(sdev->host->can_queue, ata_id_queue_depth(dev->id)); > depth = min(ATA_MAX_QUEUE, depth); > scsi_change_queue_depth(sdev, depth);
