Hi Bart,
On 5/28/23 13:30, Bart Van Assche wrote:
> On 5/27/23 16:08, Randy Dunlap wrote:
>> When I build stex.o for i386, I see these build warnings:
>
> Are you perhaps using gcc 13?
Yes.
> Has the following alternative patch been considered? I think this patch is lower risk than the patch in the original email:
>
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index 5b230e149c3d..8ffb75be99bc 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -109,7 +109,9 @@ enum {
> TASK_ATTRIBUTE_HEADOFQUEUE = 0x1,
> TASK_ATTRIBUTE_ORDERED = 0x2,
> TASK_ATTRIBUTE_ACA = 0x4,
> +};
>
> +enum {
> SS_STS_NORMAL = 0x80000000,
> SS_STS_DONE = 0x40000000,
> SS_STS_HANDSHAKE = 0x20000000,
> @@ -121,7 +123,9 @@ enum {
> SS_I2H_REQUEST_RESET = 0x2000,
>
> SS_MU_OPERATIONAL = 0x80000000,
> +};
>
> +enum {
> STEX_CDB_LENGTH = 16,
> STATUS_VAR_LEN = 128,
>
>
Yes, that also works. Thanks.
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested
--
~Randy
