On 5/23/23 12:19, Adrian Hunter wrote:
On 23/05/23 20:10, Bart Van Assche wrote:
The overhead of BLK_MQ_F_BLOCKING is small relative to the time required to
queue a UFS command so I think enabling BLK_MQ_F_BLOCKING for all UFS host
controllers is fine.
Doesn't it also force the queue to be run asynchronously always?
But in any case, it doesn't seem like something to force on drivers
just because it would take a bit more coding to make it optional.
Making BLK_MQ_F_BLOCKING optional would complicate testing of the UFS
driver. Although it is possible to make BLK_MQ_F_BLOCKING optional, I'm
wondering whether it is worth it? I haven't noticed any performance
difference in my tests with BLK_MQ_F_BLOCKING enabled compared to
BLK_MQ_F_BLOCKING disabled.
Thanks,
Bart.
